sql-server: Add behavior: auto_gc_behavior: enable. #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Auto GC is enabled, the running sql-server will periodically collect a Dolt database that is growing in size. This behavior is currently experimental. Tuning the behavior around how often to collect is ongoing work.
…s to be more reliable.
… same database as the auto GC work.
|
@coffeegoddd DOLT
|
zachmu
approved these changes
Feb 13, 2025
| @@ -113,7 +115,8 @@ func NewSqlEngine( | |||
| return nil, err | |||
| } | |||
|
|
|||
| all := dbs[:] | |||
| all := make([]dsess.SqlDatabase, len(dbs)) | |||
| copy(all, dbs) | |||
There was a problem hiding this comment.
Might add a note why making a copy here is important
| if !ok { | ||
| if store != nil { | ||
| return store.ChunkJournal() | ||
| } else { | ||
| return nil |
There was a problem hiding this comment.
Isn't this impossible? Store is set in both cases above
| // delivers when no GC is currently running. | ||
| done chan struct{} | ||
| // It simplifies the logic and efficiency of the | ||
| // implementation a bit to have a |
| type autoGCCommitHook struct { | ||
| c *AutoGCController | ||
| name string | ||
| // Always non-nil, if this channel delivers this channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Auto GC is enabled, the running sql-server will periodically collect a Dolt database that is growing in size. This behavior is currently experimental. Tuning the behavior around how often to collect is ongoing work.